Skip to content

Wizard: restrict multiple targets when creating a bp (HMS-11101) - #4747

Open
ksiekl wants to merge 2 commits into
mainfrom
single-target-radio
Open

Wizard: restrict multiple targets when creating a bp (HMS-11101)#4747
ksiekl wants to merge 2 commits into
mainfrom
single-target-radio

Conversation

@ksiekl

@ksiekl ksiekl commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

When a user creates a new blueprint, we want the target environment options to be limited to a single selection, so there will be radio buttons. However, if the user wants to edit a bp that already includes multiple target envs, we keep the checkboxes there (for now, until the migration is complete).
radiobuttons

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.84%. Comparing base (9fecf11) to head (ecb69fd).

Files with missing lines Patch % Lines
...ImageOutput/components/TargetEnvironmentOption.tsx 94.11% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4747      +/-   ##
==========================================
- Coverage   77.85%   77.84%   -0.01%     
==========================================
  Files         264      264              
  Lines        7066     7074       +8     
  Branches     2603     2604       +1     
==========================================
+ Hits         5501     5507       +6     
+ Misses       1471     1470       -1     
- Partials       94       97       +3     
Flag Coverage Δ
playwright 59.77% <43.75%> (-0.15%) ⬇️
vitest 72.80% <84.21%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...steps/ImageOutput/components/TargetEnvironment.tsx 86.31% <100.00%> (+0.14%) ⬆️
...ImageOutput/components/TargetEnvironmentOption.tsx 97.05% <94.11%> (+8.16%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fecf11...ecb69fd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ksiekl
ksiekl force-pushed the single-target-radio branch 5 times, most recently from f3ad46b to 832421c Compare August 13, 2026 13:09
@ksiekl
ksiekl marked this pull request as ready for review August 13, 2026 13:42
@ksiekl
ksiekl requested a review from a team as a code owner August 13, 2026 13:42

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@regexowl
regexowl force-pushed the single-target-radio branch from 832421c to ee0de13 Compare August 14, 2026 08:28
@regexowl

regexowl commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

The changes look great! Rebasing to get this on top of #4754, there were some flakes in boot tests that should hopefully not appear again (besides the openstack issue)

@regexowl

Copy link
Copy Markdown
Collaborator

Also one minor nitpick, this alert should be hidden for radios, but that could be easily split to a follow up.

image

ksiekl added 2 commits August 14, 2026 12:27
When a user creates a new blueprint, we want to have the options for
target environments restricted to just one selection, so there will be
radio buttons. However, if the user wants to edit a bp that already
consisted of multiple target envs, we keep the checkboxes there (for
now, until the migration is done.)
@regexowl
regexowl force-pushed the single-target-radio branch from ee0de13 to ecb69fd Compare August 14, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants